From: Jeff King <peff@peff.net>
Date: Thu, 10 Jul 2008 06:39:41 GMT
Subject: Re: [PATCH 2/4] git-imap-send: Add support for SSL.
Message-ID: <20080710063941.GC3195@sigill.intra.peff.net>
In-Reply-To: <1096648c0807091424g1e10d0ccrae0be929ec428b89@mail.gmail.com>

On Wed, Jul 09, 2008 at 10:24:27PM +0100, Rob Shearman wrote:

> >>  [imap]
> >> +    sslverify = false
> > [...]
> >> +     else if (!strcmp( "ssl_verify", key ))
> >
> > The example and the code disagree on the name of the
> > sslverify/ssl_verify option.
> 
> I wouldn't exactly call it "disagree". The config variable is limited
> by not allowing underscores, whereas the C language does allow them.

I think his point is that the example says "sslverify" but the code is
looking for the config variable "ssl_verify". So that config won't work.

However as you mention, underscore isn't allowed, so your strcmp line is
totally bogus anyway, but you silently fix it in your 3/4 "style" fix.

-Peff