From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Fri, 06 Jun 2008 13:24:15 GMT
Subject: Re: [JGIT PATCH 09/12] Add getSize() method to ObjectIdSubclassMap
Message-ID: <200806061524.15823.robin.rosenberg@dewire.com>
In-Reply-To: <1212441883-12990-10-git-send-email-marek.zawirski@gmail.com>

måndagen den 2 juni 2008 23.24.40 skrev Marek Zawirski:
> --- a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdSubclassMap.java
> +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdSubclassMap.java
> @@ -107,6 +107,15 @@ public class ObjectIdSubclassMap<V extends ObjectId> {
>  		size++;
>  	}
>  
> +	/**
> +	 * Returns number of objects in map.
> +	 * 
> +	 * @return number of objects in map
> +	 */
> +	public int size() {
> +		return size;
> +	}

Just the @return is usually enough for methods that simply return a value. If you
have both the untagged part of the comment should explain much more. Patch
10 is a good example.

-- robin