git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Show committer ident in some cases

From
Jeff King <peff@peff.net>
Date
May 5, 2008, 03:30 UTC
Message-ID
<20080505033044.GB15498@sigill.intra.peff.net>
In-Reply-To
<1209752541-19111-1-git-send-email-sbejar@gmail.com>
On Fri, May 02, 2008 at 08:22:19PM +0200, Santi Béjar wrote:
Show 14 quoted lines
> The different strategies are.. Show the committer:
> 
> 1) always
> 2) when user.warn = yes (defaulting to yes)
> 3) when it is automatic
>    a) always
>    b) and different from parent
>    c) and different from a list of valid committer idents
>    d) and when user.WarnAutomatic = yes (defaulting to yes)
> 
> The first patch implements 3a
> The second patch implements 3d
> 
> I prefer 3a.

I haven't kept up to date very well with this patch, but let me add a (possibly belated) addendum to my earlier comments: I like 3a, and I think it addresses the issues I brought up in earlier revisions.

-Peff
Previous: Santi BéjarNext: Junio C Hamano
Message 10 of 11 in “Show committer ident in some cases”
  1. 0/2 Show committer ident in some casesSanti Béjar, May 2, 2008
  2. 1/2 commit: Show committer if automaticSanti Béjar, May 2, 2008
  3. Junio C HamanoMay 3, 2008
  4. Santi BéjarMay 3, 2008
  5. 2/2 user.warnautomatic: add config to control if the committer ident is shownSanti Béjar, May 2, 2008
  6. Junio C HamanoMay 2, 2008
  7. Santi BéjarMay 2, 2008
  8. Junio C HamanoMay 2, 2008
  9. Santi BéjarMay 3, 2008
  10. Jeff KingMay 5, 2008
  11. Junio C HamanoMay 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.