From: Jeff King <peff@peff.net>
Date: Mon, 05 May 2008 03:30:44 GMT
Subject: Re: [PATCH 0/2] Show committer ident in some cases
Message-ID: <20080505033044.GB15498@sigill.intra.peff.net>
In-Reply-To: <1209752541-19111-1-git-send-email-sbejar@gmail.com>

On Fri, May 02, 2008 at 08:22:19PM +0200, Santi Béjar wrote:

> The different strategies are.. Show the committer:
> 
> 1) always
> 2) when user.warn = yes (defaulting to yes)
> 3) when it is automatic
>    a) always
>    b) and different from parent
>    c) and different from a list of valid committer idents
>    d) and when user.WarnAutomatic = yes (defaulting to yes)
> 
> The first patch implements 3a
> The second patch implements 3d
> 
> I prefer 3a.

I haven't kept up to date very well with this patch, but let me add a
(possibly belated) addendum to my earlier comments: I like 3a, and I
think it addresses the issues I brought up in earlier revisions.

-Peff