Re: [PATCH 0/2] Show committer ident in some cases

From: Junio C Hamano <gitster@pobox.com>
Date: May 5, 2008, 05:23 UTC
Message-ID: <7vhcddnx31.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080505033044.GB15498@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 20 quoted lines

> On Fri, May 02, 2008 at 08:22:19PM +0200, Santi Béjar wrote:
>
>> The different strategies are.. Show the committer:
>> 
>> 1) always
>> 2) when user.warn = yes (defaulting to yes)
>> 3) when it is automatic
>>    a) always
>>    b) and different from parent
>>    c) and different from a list of valid committer idents
>>    d) and when user.WarnAutomatic = yes (defaulting to yes)
>> 
>> The first patch implements 3a
>> The second patch implements 3d
>> 
>> I prefer 3a.
>
> I haven't kept up to date very well with this patch, but let me add a
> (possibly belated) addendum to my earlier comments: I like 3a, and I
> think it addresses the issues I brought up in earlier revisions.

I tend to agree.

I usually _really_ hate any patch that adds noise that punishes people whose system is configured and maintained well.

The 3a approach punishes people on a well maintained system where you would get a good value out of GECOS and gethostname(2) by forcing them to duplicate the information in their .git/config (or $HOME/.gitconfig). So I should be hating the idea, but I think alternatives are much worse than that, and it is the least problematic.