Re: [PATCH 0/2] Show committer ident in some cases

From: Junio C Hamano <gitster@pobox.com>
Date: May 2, 2008, 22:32 UTC
Message-ID: <7vbq3owd4o.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <8aa486160805021507s44d7946ejc48ac8a4af08e8cc@mail.gmail.com>

"Santi Béjar" <sbejar@gmail.com> writes:

Show 15 quoted lines

> On Fri, May 2, 2008 at 11:44 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Santi Béjar <sbejar@gmail.com> writes:
>>
>>  > The definition of "wrong committer" could be:
>>  >
>>  > 1) user.{name,email} or GIT_COMMITTER_{NAME,EMAIL} is not a wrong committer.
>>  > 2) automatic without a domain name (user@hostname.(none)) is a wrong committer.
>>  >    (not handled with this patch series)
>>  > 3) automatic or partially set ident:
>>  >    a) wrong committer for some users
>>  >    b) right committer for others
>>
>>  Define "partially set".
>
> one of user.{name,email} is not set.

Hmmm.  Then perhaps the list can be simplified as follows?

 * Both name and email are explicitly given (i.e. user.* or
   GIT_COMMITTER_* specifies them) --- no complaints.

 * For email, ending with ".(none)" and "@" followed by something without
   a dot is wrong but everything else are Ok.

 * Everything else falls into (3)

There is no "partially" then.

By the way, wasn't it you who wanted to refuse use of user.name _and_ user.email that come from ~/.gitconfig, so that you can be sure you use different pseudonym for each project?