git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git-diff-* --color oddness

From
Jeff King <peff@peff.net>
Date
Jan 4, 2008, 08:28 UTC
Message-ID
<20080104082842.GA3300@coredump.intra.peff.net>
In-Reply-To
<7vejcym21q.fsf@gitster.siamese.dyndns.org>
On Fri, Jan 04, 2008 at 12:24:01AM -0800, Junio C Hamano wrote:
Show 5 quoted lines
> > Ordinarily, I would say "nobody should use --color with diff-files". But
> > we do, in git-add--interactive (see Wincent's 4af756f3).
> 
> The plumbing deliberately not calling ui_config does not have
> anything to do with them supporting explicit --color options.

I'm not sure what you mean here. Are you saying that it is the desired behavior for "git-diff --color" to use my color.diff.* variables, but for "git-diff-files --color" not to?

I think that's insane, and it makes "git-add -i" depending on git-diff-file's colorization wrong (since in other parts it uses the color.diff.* variables).

Not to mention the other bug (that diff-files _does_ read the config, just halfway through).

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 12 in “[BUG] git-diff-* --color oddness”
  1. Jeff KingJan 4, 2008
  2. Junio C HamanoJan 4, 2008
  3. Jeff KingJan 4, 2008
  4. Junio C HamanoJan 4, 2008
  5. Jeff KingJan 4, 2008
  6. Junio C HamanoJan 4, 2008
  7. Jeff KingJan 4, 2008
  8. Junio C HamanoJan 4, 2008
  9. Jeff KingJan 4, 2008
  10. Jeff KingJan 4, 2008
  11. Junio C HamanoJan 4, 2008
  12. Jeff KingJan 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.