From: Jeff King <peff@peff.net>
Date: Fri, 04 Jan 2008 08:28:42 GMT
Subject: Re: [BUG] git-diff-* --color oddness
Message-ID: <20080104082842.GA3300@coredump.intra.peff.net>
In-Reply-To: <7vejcym21q.fsf@gitster.siamese.dyndns.org>

On Fri, Jan 04, 2008 at 12:24:01AM -0800, Junio C Hamano wrote:

> > Ordinarily, I would say "nobody should use --color with diff-files". But
> > we do, in git-add--interactive (see Wincent's 4af756f3).
> 
> The plumbing deliberately not calling ui_config does not have
> anything to do with them supporting explicit --color options.

I'm not sure what you mean here. Are you saying that it is the desired
behavior for "git-diff --color" to use my color.diff.* variables, but
for "git-diff-files --color" not to?

I think that's insane, and it makes "git-add -i" depending on
git-diff-file's colorization wrong (since in other parts it uses the
color.diff.* variables).

Not to mention the other bug (that diff-files _does_ read the config,
just halfway through).

-Peff