git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git-diff-* --color oddness

From
Jeff King <peff@peff.net>
Date
Jan 4, 2008, 08:32 UTC
Message-ID
<20080104083252.GB3300@coredump.intra.peff.net>
In-Reply-To
<7vabnmm1ww.fsf@gitster.siamese.dyndns.org>
On Fri, Jan 04, 2008 at 12:26:55AM -0800, Junio C Hamano wrote:
Show 8 quoted lines
> > The first two lines of meta-info will be in the stock colors, but
> > everything after will be in the custom colors. So we are actually
> > reading the diff_ui options _during_ the diff. The culprit is
> > funcname_pattern, which calls read_config_if_needed.
> 
> Yuck.  Why is funcname_pattern do ui-config stuff?  I know it
> wants to get custom regexp crap, but that should belong to the
> plumbing part, not Porcelain-only thing, shouldn't it?

It's for user diff drivers, and it looks like the funcname pattern. Not sure why we want to demand-load that stuff at all...I wonder if it should just go into git_default_config (or a git_basic_diff_config).

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 12 in “[BUG] git-diff-* --color oddness”
  1. Jeff KingJan 4, 2008
  2. Junio C HamanoJan 4, 2008
  3. Jeff KingJan 4, 2008
  4. Junio C HamanoJan 4, 2008
  5. Jeff KingJan 4, 2008
  6. Junio C HamanoJan 4, 2008
  7. Jeff KingJan 4, 2008
  8. Junio C HamanoJan 4, 2008
  9. Jeff KingJan 4, 2008
  10. Jeff KingJan 4, 2008
  11. Junio C HamanoJan 4, 2008
  12. Jeff KingJan 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.