Re: [BUG] git-diff-* --color oddness

From

Junio C Hamano <gitster@pobox.com>

Date

Jan 4, 2008, 08:24 UTC

Message-ID

<7vejcym21q.fsf@gitster.siamese.dyndns.org>

In-Reply-To

<20080104081429.GA30635@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I encountered some weirdness today with git-diff-{files,tree,index} and
> --color.  They parse the --color command line option, but do _not_ call
> git_config(git_diff_ui_config), so if the user has colors specified in
> the config, they are not used.

This is very deliberate.  ui_config is about the Porcelains.

> Ordinarily, I would say "nobody should use --color with diff-files". But
> we do, in git-add--interactive (see Wincent's 4af756f3).