Re: [RFH] convert shortlog to use parse_options

From: Jeff King <peff@peff.net>
Date: Dec 13, 2007, 09:10 UTC
Message-ID: <20071213091055.GA5674@coredump.intra.peff.net>
In-Reply-To: <20071213090604.GA12398@artemis.madism.org>

On Thu, Dec 13, 2007 at 10:06:04AM +0100, Pierre Habouzit wrote:

Show 5 quoted lines

> No we can't. And I believe that such a thing is definitely bad practice
> :/ So if you really need to, we will have to add some PARSE_OPT_STICKARG
> or sth alike that would check that the argument was "sticked" to the
> option either with `-wA,B,C` or `--long-opt=A,B,C` depending on the fact
> that an option is short or long.

Yes, I am not sure if the right solution is to just say "we are changing how -w works". Because it either must change, or it must be inconsistent with the rest of the option parsing for the rest of eternity.

> Though note that you can't migrate things that use init_revisions and so
> on to parseoptions yet, because revisions also have dashed tokens (--not
> e.g.) and that the first run of parse_options will just hate it and

Ah, yes. I hadn't really considered that angle yet (my basic testing had just been on non-dashed revision parameters).

I will table this patch for now, then, since it obviously is too complex for v1.5.4.

Thanks for your input.

-Peff