Re: [RFH] convert shortlog to use parse_options

From: Pierre Habouzit <madcoder@debian.org>
Date: Dec 13, 2007, 09:06 UTC
Message-ID: <20071213090604.GA12398@artemis.madism.org>
In-Reply-To: <20071213055226.GA3636@coredump.intra.peff.net>

On Thu, Dec 13, 2007 at 05:52:26AM +0000, Jeff King wrote:

Show 13 quoted lines

> Pierre,
> 
> I am converting shortlog to use parse_options, but I have hit a behavior
> I can't seem to represent.
> 
> The "-w" option has an optional argument, and we used to accept only
> "-w" or "-wX,Y,Z". However, parse_options allows "-w X,Y,Z".
> 
> This means that "-w HEAD" used to mean "turn on wrapping
> with default parameters, look at HEAD" and now translates to
> "-w with parameter HEAD".
> 
> Is there a way to do this currently, or can we add an option flag?

No we can't. And I believe that such a thing is definitely bad practice :/ So if you really need to, we will have to add some PARSE_OPT_STICKARG or sth alike that would check that the argument was "sticked" to the option either with `-wA,B,C` or `--long-opt=A,B,C` depending on the fact that an option is short or long.

Though: `git shortlog -w -- HEAD` will work properly because option
arguments don't take the next token as an argument thing if it starts
with a dash.

Though note that you can't migrate things that use init_revisions and so on to parseoptions yet, because revisions also have dashed tokens (--not e.g.) and that the first run of parse_options will just hate it and fail. Maybe we can do parse_options work in multiple passes though, but that would require a quite extensive rethought of the module, the introduction of a parseopt context to be freed after the last pass (because we will have a lot of small allocation stuff going on). I'll try to see what I can do in that direction.

For that we must migrate diff and revisions option parser as big macros (I started[0] it but didn't had the time to complete it yet, and it's quite a huge task, because there is no incremental upgrade path here, and there are commands using both diff and revisions options so we must migrate both at once) and use aggregated parseoptions specifiers.

  [0] http://git.madism.org/?p=git.git;a=commitdiff;h=059cfb6d4cfbdff68d81577d00c9dbce6fed443e

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org