Re: [PATCH 2/4] Teach git-add--interactive to accept a file path to patch

From: Jeff King <peff@peff.net>
Date: Nov 22, 2007, 11:36 UTC
Message-ID: <20071122113600.GB12913@sigill.intra.peff.net>
In-Reply-To: <7vlk8q5xj4.fsf@gitster.siamese.dyndns.org>

On Thu, Nov 22, 2007 at 03:29:03AM -0800, Junio C Hamano wrote:

Show 9 quoted lines

> There was one funny thing I fixed up.  The arguments to the
> interactive_add() function in builtin-add.c was like this:
> 
> 	int interactive_add(const char **argv, int argc)
> 
> Anybody who writes a function with such a signature and do not
> notice its craziness before sending it out either (1) has never
> programmed in C, (2) did not review the code before submitting,
> or (3) worked too hard and was too tired.

Heh. I looked the patch over, noticed a subtle memcpy issue, and didn't even notice the craziness. I claim 3, also.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.