From: Jeff King <peff@peff.net>
Date: Thu, 22 Nov 2007 11:36:00 GMT
Subject: Re: [PATCH 2/4] Teach git-add--interactive to accept a file path to patch
Message-ID: <20071122113600.GB12913@sigill.intra.peff.net>
In-Reply-To: <7vlk8q5xj4.fsf@gitster.siamese.dyndns.org>

On Thu, Nov 22, 2007 at 03:29:03AM -0800, Junio C Hamano wrote:

> There was one funny thing I fixed up.  The arguments to the
> interactive_add() function in builtin-add.c was like this:
> 
> 	int interactive_add(const char **argv, int argc)
> 
> Anybody who writes a function with such a signature and do not
> notice its craziness before sending it out either (1) has never
> programmed in C, (2) did not review the code before submitting,
> or (3) worked too hard and was too tired.

Heh. I looked the patch over, noticed a subtle memcpy issue, and didn't
even notice the craziness. I claim 3, also.

-Peff