Re: [PATCH 2/4] Teach git-add--interactive to accept a file path to patch

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 22, 2007, 00:18 UTC
Message-ID: <7vk5obb09a.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <C6E820C8-91E9-48B2-9219-377CA83163A7@wincent.com>

Wincent Colaiuta <win@wincent.com> writes:

Show 5 quoted lines

> - Junio, do you mean to suggest with your comment that when passing
> untracked files either directly or indirectly (ie. when passing a dir
> containing untracked files) that they should be added (ie. invoked the
> "add untracked" subcommand) in addition to running the "patch"
> subcommand on the changed files?

What I meant was that if "git add -i" (unrestricted) shows paths from a set A, "git add -i paths..." should show paths from a subset of the set A and that subset should be defined with the existing ls-files pathspec semantics.

For example, if "(a)dd untracked" subcommand shows all untracked files when "add -i" was invoked without paths limitation, the restricted form "add -i paths..." would show only untracked paths that match the given set of patterns. If "(p)atch" subcommand shows all modified tracked files when "add -i" was invoked without paths limitation, the restricted form "add -i paths..." would show only such modified tracked files whose names match the given set of patterns.