Re: [PATCH 3/4] Teach builtin-add to pass multiple paths to git-add--interactive
- From
Jeff King <peff@peff.net>
- Date
- Nov 22, 2007, 10:33 UTC
- Message-ID
- <20071122103339.GA12692@sigill.intra.peff.net>
- In-Reply-To
- <825BAB3C-FAB4-4A48-AB94-FAAF5B808CD1@wincent.com>
On Thu, Nov 22, 2007 at 11:28:17AM +0100, Wincent Colaiuta wrote:
Show 9 quoted lines
>>> + memcpy((void *)args + sizeof(const char *), argv, sizeof(const char *) * >>> argc); >> >> The source for the memcpy (argv) is sometimes NULL. The standard forbids >> this, even when the size field is 0. I have no idea if any reasonable >> implementations actually care. > > Good point. I've now conditionalized the memcpy with an "if (argc > 0)". > While I was at it I also got rid of the unneeded cast to void *.
I don't think you need it if you do the other cleanup (since you will always be passing a valid argv pointer).
-Peff