Re: [PATCH 0/5] some shell portability fixes

From: Ralf Wildenhues <ralf.wildenhues@gmx.de>
Date: Nov 8, 2007, 06:14 UTC
Message-ID: <20071108061456.GA28509@ins.uni-bonn.de>
In-Reply-To: <7v3avhbxdq.fsf@gitster.siamese.dyndns.org>

* Junio C Hamano wrote on Wed, Nov 07, 2007 at 09:42:41PM CET:

Show 15 quoted lines

> "Nguyen Thai Ngoc Duy" <pclouds@gmail.com> writes:
> >
> > Argh, should have made it clear, busybox sed is good enough.
> 
> Thanks.  And you can also happy grok Ralf's rewritten construct,
> right?
> 
> That is, existing
> 
>         $ sed -e 's/foo/\n/' file
> 
> will be rewritten by the patch [2/5] to
> 
>         $ sed -e 's/foo/\
>         /' file

The original was something like
  sed 's/[|]/\n/g'

Using instead
  tr '|' '\n'

should work for the original construct, and AFAIK only /usr/ucb/tr on
Solaris fails to understand \n correctly.  Would that be better for you?
Or even
  tr '|' '\012'

which fails only on EBCDIC, which I don't think git targets.

I'll resend the patches tonight.

Cheers, Ralf