git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/5] Avoid "test -o" and "test -a" which are not POSIX, only XSI.

From
RWRalf Wildenhues <ralf.wildenhues@gmx.de>
Date
Nov 6, 2007, 20:20 UTC
Message-ID
<20071106202035.GF6361@ins.uni-bonn.de>
In-Reply-To
<20071106201518.GA6361@ins.uni-bonn.de>
---
 git-clone.sh        |    2 +-
 git-commit.sh       |    4 ++--
 git-merge-stupid.sh |    2 +-
 git-merge.sh        |    4 ++--
 git-mergetool.sh    |    2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/git-clone.sh b/git-clone.sh
index 3f00693..1ae137a 100755
--- a/git-clone.sh
+++ b/git-clone.sh
@@ -462,7 +462,7 @@ then
 
 	case "$no_checkout" in
 	'')
-		test "z$quiet" = z -a "z$no_progress" = z && v=-v || v=
+		test "z$quiet" = z && test "z$no_progress" = z && v=-v || v=
 		git read-tree -m -u $v HEAD HEAD
 	esac
 fi
diff --git a/git-commit.sh b/git-commit.sh
index fcb8443..78fe518 100755
--- a/git-commit.sh
+++ b/git-commit.sh
@@ -50,7 +50,7 @@ run_status () {
 		export GIT_INDEX_FILE
 	fi
 
-	if test "$status_only" = "t" -o "$use_status_color" = "t"; then
+	if test "$status_only" = "t" || test "$use_status_color" = "t"; then
 		color=
 	else
 		color=--nocolor
@@ -290,7 +290,7 @@ t,,[1-9]*)
 	die "No paths with -i does not make sense." ;;
 esac
 
-if test ! -z "$templatefile" -a -z "$log_given"
+if test ! -z "$templatefile" && test -z "$log_given"
 then
 	if test ! -f "$templatefile"
 	then
diff --git a/git-merge-stupid.sh b/git-merge-stupid.sh
index f612d47..95adbb3 100755
--- a/git-merge-stupid.sh
+++ b/git-merge-stupid.sh
@@ -44,7 +44,7 @@ case "$bases" in
 			 2>/dev/null ||	continue
 		# Count the paths that are unmerged.
 		cnt=`GIT_INDEX_FILE=$G git ls-files --unmerged | wc -l`
-		if test $best_cnt -le 0 -o $cnt -le $best_cnt
+		if test $best_cnt -le 0 || test $cnt -le $best_cnt
 		then
 			best=$c
 			best_cnt=$cnt
diff --git a/git-merge.sh b/git-merge.sh
index c2092a2..b6a35d4 100755
--- a/git-merge.sh
+++ b/git-merge.sh
@@ -124,7 +124,7 @@ merge_name () {
 		git show-ref -q --verify "refs/heads/$truname" 2>/dev/null
 	then
 		echo "$rh		branch '$truname' (early part) of ."
-	elif test "$remote" = "FETCH_HEAD" -a -r "$GIT_DIR/FETCH_HEAD"
+	elif test "$remote" = "FETCH_HEAD" && test -r "$GIT_DIR/FETCH_HEAD"
 	then
 		sed -e 's/	not-for-merge	/		/' -e 1q \
 			"$GIT_DIR/FETCH_HEAD"
@@ -478,7 +478,7 @@ do
 		git diff-files --name-only
 		git ls-files --unmerged
 	    } | wc -l`
-	    if test $best_cnt -le 0 -o $cnt -le $best_cnt
+	    if test $best_cnt -le 0 || test $cnt -le $best_cnt
 	    then
 		best_strategy=$strategy
 		best_cnt=$cnt
diff --git a/git-mergetool.sh b/git-mergetool.sh
index a68b403..9f7386b 100755
--- a/git-mergetool.sh
+++ b/git-mergetool.sh
@@ -167,7 +167,7 @@ merge_file () {
     local_present  && git cat-file blob ":2:$prefix$path" >"$LOCAL" 2>/dev/null
     remote_present && git cat-file blob ":3:$prefix$path" >"$REMOTE" 2>/dev/null
 
-    if test -z "$local_mode" -o -z "$remote_mode"; then
+    if test -z "$local_mode" || test -z "$remote_mode"; then
 	echo "Deleted merge conflict for '$path':"
 	describe_file "$local_mode" "local" "$LOCAL"
 	describe_file "$remote_mode" "remote" "$REMOTE"
-- 
1.5.3.5.561.g140d
Previous: Ralf WildenhuesNext: Junio C Hamano
Message 24 of 38 in “some shell portability fixes”
  1. 0/5 some shell portability fixesRalf Wildenhues, Nov 6, 2007
  2. 1/5 Avoid a few unportable, needlessly nested "...`...".Ralf Wildenhues, Nov 6, 2007
  3. 2/5 Fix sed script to work with AIX sed.Ralf Wildenhues, Nov 6, 2007
  4. Ralf WildenhuesNov 6, 2007
  5. Ralf WildenhuesNov 6, 2007
  6. Junio C HamanoNov 6, 2007
  7. Add Documentation/CodingStyleJohannes Schindelin, Nov 6, 2007
  8. Andreas EricssonNov 7, 2007
  9. Junio C HamanoNov 7, 2007
  10. Andreas EricssonNov 7, 2007
  11. Add Documentation/CodingStyleJohannes Schindelin, Nov 7, 2007
  12. Robin RosenbergNov 7, 2007
  13. Add Documentation/CodingGuidelinesJohannes Schindelin, Nov 7, 2007
  14. Junio C HamanoNov 7, 2007
  15. Add Documentation/CodingGuidelinesJohannes Schindelin, Nov 8, 2007
  16. Junio C HamanoNov 8, 2007
  17. Johannes SchindelinNov 7, 2007
  18. Wincent ColaiutaNov 7, 2007
  19. Andreas EricssonNov 7, 2007
  20. Jon LoeligerNov 7, 2007
  21. Johannes SchindelinNov 7, 2007
  22. Mike RalphsonNov 8, 2007
  23. 4/5 Fix sed string regex escaping in module_name.Ralf Wildenhues, Nov 6, 2007
  24. 5/5 Avoid "test -o" and "test -a" which are not POSIX, only XSI.Ralf Wildenhues, Nov 6, 2007
  25. Junio C HamanoNov 6, 2007
  26. Mike HommeyNov 6, 2007
  27. Johannes SchindelinNov 6, 2007
  28. Mike RalphsonNov 7, 2007
  29. Johannes SchindelinNov 7, 2007
  30. Mike RalphsonNov 7, 2007
  31. Johannes SchindelinNov 7, 2007
  32. Ralf WildenhuesNov 6, 2007
  33. Nguyen Thai Ngoc DuyNov 7, 2007
  34. Nguyen Thai Ngoc DuyNov 7, 2007
  35. Junio C HamanoNov 7, 2007
  36. Ralf WildenhuesNov 8, 2007
  37. Nguyen Thai Ngoc DuyNov 12, 2007
  38. Miles BaderNov 10, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.