git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] "git help -a" should search all exec_paths and PATH

From
Scott Parish <srp@srparish.net>
Date
Oct 22, 2007, 00:54 UTC
Message-ID
<20071022005429.GK16291@srparish.net>
In-Reply-To
<Pine.LNX.4.64.0710212323580.25221@racer.site>
On Sun, Oct 21, 2007 at 11:25:29PM +0100, Johannes Schindelin wrote:
Show 6 quoted lines
> > To fix this, help.c is modified to search in all the exec_paths and PATH
> > for potential git commands.
> 
> With this explanation, I would have expected that you add a loop just like 
> in exec-cmd.c.  Not anything more.  And certainly not the removal of a 
> sanity check for the length of the path name.

Well, i took a slightly different approach where that sanity check wasn't nessisary. Instead of building up a string of the path of each file, i'm saving the original directory in a file descriptor, and "cd"ing to the exec_path currently being listed. Because of that i can just stat() the names returned by readdir. Much simpler imho

sRp
-- 
Scott Parish
http://srparish.net/
Previous: Johannes SchindelinNext: Shawn O. Pearce
Message 3 of 7 in “"git help -a" should search all exec_paths and PATH”
  1. "git help -a" should search all exec_paths and PATHScott R Parish, Oct 21, 2007
  2. Johannes SchindelinOct 21, 2007
  3. Scott ParishOct 22, 2007
  4. Shawn O. PearceOct 22, 2007
  5. Scott ParishOct 22, 2007
  6. Shawn O. PearceOct 22, 2007
  7. Johannes SixtOct 22, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.