From: Scott Parish <srp@srparish.net>
Date: Mon, 22 Oct 2007 00:54:30 GMT
Subject: Re: [PATCH] "git help -a" should search all exec_paths and PATH
Message-ID: <20071022005429.GK16291@srparish.net>
In-Reply-To: <Pine.LNX.4.64.0710212323580.25221@racer.site>

On Sun, Oct 21, 2007 at 11:25:29PM +0100, Johannes Schindelin wrote:

> > To fix this, help.c is modified to search in all the exec_paths and PATH
> > for potential git commands.
> 
> With this explanation, I would have expected that you add a loop just like 
> in exec-cmd.c.  Not anything more.  And certainly not the removal of a 
> sanity check for the length of the path name.

Well, i took a slightly different approach where that sanity check
wasn't nessisary. Instead of building up a string of the path of
each file, i'm saving the original directory in a file descriptor,
and "cd"ing to the exec_path currently being listed. Because of
that i can just stat() the names returned by readdir. Much simpler
imho

sRp

-- 
Scott Parish
http://srparish.net/