Re: [PATCH] "git help -a" should search all exec_paths and PATH

From: Shawn O. Pearce <spearce@spearce.org>
Date: Oct 22, 2007, 06:39 UTC
Message-ID: <20071022063933.GU14735@spearce.org>
In-Reply-To: <20071022063201.GN16291@srparish.net>

Scott Parish <sRp@srparish.net> wrote:

Show 13 quoted lines

> On Mon, Oct 22, 2007 at 01:30:17AM -0400, Shawn O. Pearce wrote:
> 
> > fchdir() isn't as portable as Git currently is.
> 
> I hadn't realized it wasn't portable, but i do see that there's no POSIX
> entry in its man page. I was actually looking to use getcwd, but its
> man page had suggested using this open()/fchdir() method.
> 
> Anyway, is there a reason to avoid changing the directory? If not
> i'm tempted to take the approach that j.sixt suggested--not restoring
> the cwd since we're exiting anyway. I don't have any good reason
> to not do the string manipulation, but why do something more
> complicated then necessary?

Yea, that was another thought I had. You probably can just chdir(), list, exit, and not worry about going back to the previous directory. And more complicated is always a bad idea. Keep it simple, 'cause us gits like it that way. :-)

-- 
Shawn.