Re: [PATCH] Change "refs/" references to symbolic constants

From: Jeff King <peff@peff.net>
Date: Oct 3, 2007, 04:30 UTC
Message-ID: <20071003043058.GA11905@coredump.intra.peff.net>
In-Reply-To: <Pine.LNX.4.64.0710030503520.28395@racer.site>

On Wed, Oct 03, 2007 at 05:05:15AM +0100, Johannes Schindelin wrote:

Show 8 quoted lines

> I wonder, I wonder, if
> 
> 	strbuf_addstr(&url, repo->base);
> 	strbuf_addstr(&url, "/objects/pack/pack-");
> 	strbuf_addstr(&url, hex);
> 	strbuf_addstr(&url, ".idx");
> 
> would make anybody else but me happy...

I actually wrote that originally, and then switched to the formatted version for readability. But I would be happy with that, as well, if we are truly concerned about the cost of 2 snprintfs.

-Peff