From: Jeff King Date: Wed, 03 Oct 2007 04:30:58 GMT Subject: Re: [PATCH] Change "refs/" references to symbolic constants Message-ID: <20071003043058.GA11905@coredump.intra.peff.net> In-Reply-To: On Wed, Oct 03, 2007 at 05:05:15AM +0100, Johannes Schindelin wrote: > I wonder, I wonder, if > > strbuf_addstr(&url, repo->base); > strbuf_addstr(&url, "/objects/pack/pack-"); > strbuf_addstr(&url, hex); > strbuf_addstr(&url, ".idx"); > > would make anybody else but me happy... I actually wrote that originally, and then switched to the formatted version for readability. But I would be happy with that, as well, if we are truly concerned about the cost of 2 snprintfs. -Peff