Re: [PATCH 1/2] Change "refs/" references to symbolic constants

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 2, 2007, 17:59 UTC
Message-ID: <7v1wcdmm7p.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200710020941.05288.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

> I noticed a couple of places where memcmp() has been used where prefixcmp() 
> would work fine.  I'm tempted to change them too - what do you think?  
> Perhaps a separate patch?

In general, probably it is preferable to have a separate "preliminary patch" to normalize the existing code without using the new infrastructure (i.e. REF_* macros), and then to have the main patch. That way would make the main patch more about mechanical conversion, which would be easier to verify independently.