Re: [PATCH] Change "refs/" references to symbolic constants

From: Jeff King <peff@peff.net>
Date: Oct 3, 2007, 02:58 UTC
Message-ID: <20071003025853.GA11440@coredump.intra.peff.net>
In-Reply-To: <7vr6kdhwsg.fsf@gitster.siamese.dyndns.org>

On Tue, Oct 02, 2007 at 05:22:23PM -0700, Junio C Hamano wrote:

> >   strbuf_init(&url);
> >   strbuf_addf(&url, "%s/objects/pack/pack-%s.idx", repo->base, hex);
> 
> Ugh, this typically calls snprintf() twice doesn't it?

Yes, it probably does. However, I think it is considerably easier to read and more maintainable. Are you "ugh"ing because of the performance impact (which should be negligible unless this is in a tight loop) or because of the portability problems associated with va_copy?

-Peff