git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fixed non portable use of expr, and incorrect use of test -eq for string comparison.

From
Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Date
Aug 22, 2007, 12:21 UTC
Message-ID
<20070822122140.GB11926@informatik.uni-freiburg.de>
In-Reply-To
<11877841633473-git-send-email-david@olrik.dk>
Hello,
David Jack Olrik wrote:
> -	if test "`expr index $httpd_only /`" -eq '1' || \
> +	if test "`echo $httpd_only | cut -c 1`" = '/' || \
>  				which $httpd_only >/dev/null
I wonder why not use:
	if expr "z$httpd_only" : "z/" >/dev/null

Best regards Uwe

-- 
Uwe Kleine-König

exit vi, lesson II:
: w q ! <CR>

NB: write the current file
Previous: David Jack OlrikNext: David Jack Olrik
Message 2 of 11 in “Fixed non portable use of expr, and incorrect use of test -eq for string comparison.”
  1. Fixed non portable use of expr, and incorrect use of test -eq for string comparison.David Jack Olrik, Aug 22, 2007
  2. Uwe Kleine-KönigAug 22, 2007
  3. David Jack OlrikAug 22, 2007
  4. Uwe Kleine-KönigAug 22, 2007
  5. Fixed non portable use of expr and removed incorrect use of test -eq for string comparisonDavid Jack Olrik, Aug 22, 2007
  6. Junio C HamanoAug 22, 2007
  7. Uwe Kleine-KönigAug 23, 2007
  8. Junio C HamanoAug 23, 2007
  9. Uwe Kleine-KönigAug 23, 2007
  10. Uwe Kleine-KönigAug 23, 2007
  11. martin f krafftAug 22, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.