From: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Date: Wed, 22 Aug 2007 12:21:40 GMT
Subject: Re: [PATCH] Fixed non portable use of expr, and incorrect use of test -eq for string comparison.
Message-ID: <20070822122140.GB11926@informatik.uni-freiburg.de>
In-Reply-To: <11877841633473-git-send-email-david@olrik.dk>

Hello,

David Jack Olrik wrote:
> -	if test "`expr index $httpd_only /`" -eq '1' || \
> +	if test "`echo $httpd_only | cut -c 1`" = '/' || \
>  				which $httpd_only >/dev/null

I wonder why not use:

	if expr "z$httpd_only" : "z/" >/dev/null

Best regards
Uwe

-- 
Uwe Kleine-König

exit vi, lesson II:
: w q ! <CR>

NB: write the current file