git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fixed non portable use of expr, and incorrect use of test -eq for string comparison.

From
David Jack Olrik <david@olrik.dk>
Date
Aug 22, 2007, 12:02 UTC
Message-ID
<11877841633473-git-send-email-david@olrik.dk>
Signed-off-by: David Jack Olrik <david@olrik.dk>
---
 git-instaweb.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-instaweb.sh b/git-instaweb.sh
index b79c6b6..da8eb3f 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -30,7 +30,7 @@ test -z "$port" && port=1234
 
 start_httpd () {
 	httpd_only="`echo $httpd | cut -f1 -d' '`"
-	if test "`expr index $httpd_only /`" -eq '1' || \
+	if test "`echo $httpd_only | cut -c 1`" = '/' || \
 				which $httpd_only >/dev/null
 	then
 		$httpd $fqgitdir/gitweb/httpd.conf
-- 
1.5.3.rc6
Next: Uwe Kleine-König
Message 1 of 11 in “Fixed non portable use of expr, and incorrect use of test -eq for string comparison.”
  1. Fixed non portable use of expr, and incorrect use of test -eq for string comparison.David Jack Olrik, Aug 22, 2007
  2. Uwe Kleine-KönigAug 22, 2007
  3. David Jack OlrikAug 22, 2007
  4. Uwe Kleine-KönigAug 22, 2007
  5. Fixed non portable use of expr and removed incorrect use of test -eq for string comparisonDavid Jack Olrik, Aug 22, 2007
  6. Junio C HamanoAug 22, 2007
  7. Uwe Kleine-KönigAug 23, 2007
  8. Junio C HamanoAug 23, 2007
  9. Uwe Kleine-KönigAug 23, 2007
  10. Uwe Kleine-KönigAug 23, 2007
  11. martin f krafftAug 22, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.