Re: [PATCH] Fixed non portable use of expr, and incorrect use of test -eq for string comparison.

From: David Jack Olrik <david@olrik.dk>
Date: Aug 22, 2007, 12:30 UTC
Message-ID: <9E40DAA3-69E5-417C-8041-E1980E42DB60@olrik.dk>
In-Reply-To: <20070822122140.GB11926@informatik.uni-freiburg.de>

On 22/08/2007, at 14.21, Uwe Kleine-König wrote:

Show 8 quoted lines

> David Jack Olrik wrote:
>> -	if test "`expr index $httpd_only /`" -eq '1' || \
>> +	if test "`echo $httpd_only | cut -c 1`" = '/' || \
>>  				which $httpd_only >/dev/null
>
> I wonder why not use:
>
> 	if expr "z$httpd_only" : "z/" >/dev/null

You'd then need to check against 2 instead of 1, which I find less obvious as we are testing for a '/' at the begining of the string.

-- 
Best regards,
David Jack Olrik <david@olrik.dk>             http://david.olrik.dk
GnuPG fingerprint C290 0A4A 0CCC CBA8 2B37 E18D 01D2 F6EF 2E61 9894
["The first rule of Perl club is  You do not talk about Perl club"]