git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gitk problems: can't unset "idinlist(...)"

From
Jeff King <peff@peff.net>
Date
Jul 21, 2007, 06:54 UTC
Message-ID
<20070721065405.GA9793@coredump.intra.peff.net>
In-Reply-To
<alpine.LFD.0.999.0707202335570.27249@woody.linux-foundation.org>
On Fri, Jul 20, 2007 at 11:47:24PM -0700, Linus Torvalds wrote:
> So the difference between your version and mine is that the
> 
> 	while ((p = *pp) != NULL)

I actually like your version better (I like saving for loops for honest-to-god, for-each-element-in-this-list iteration; munging the list in the middle is something that you _should_ call attention to). I just found your patch much harder to verify, because I had to make sure the for/while change was equivalent. So you can blame Junio for writing it wrong in the first place. :)

Junio, whatever you apply, please credit Linus; he beat me to the fix and so my patch is completely cribbed from his. :)

-Peff
Previous: Linus TorvaldsNext: David Kastrup
Message 11 of 15 in “gitk problems: can't unset "idinlist(...)"”
  1. Linus TorvaldsJul 20, 2007
  2. Jeff KingJul 21, 2007
  3. Linus TorvaldsJul 21, 2007
  4. Junio C HamanoJul 21, 2007
  5. Jeff KingJul 21, 2007
  6. Jeff KingJul 21, 2007
  7. Linus TorvaldsJul 21, 2007
  8. Jeff KingJul 21, 2007
  9. Jeff KingJul 21, 2007
  10. Linus TorvaldsJul 21, 2007
  11. Jeff KingJul 21, 2007
  12. pointer to pointer (was: gitk problems: can't unset "idinlist(...)")David Kastrup, Jul 21, 2007
  13. David KastrupJul 21, 2007
  14. Linus TorvaldsJul 21, 2007
  15. Paul MackerrasJul 21, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.