From: Jeff King <peff@peff.net>
Date: Sat, 21 Jul 2007 06:54:05 GMT
Subject: Re: gitk problems: can't unset "idinlist(...)"
Message-ID: <20070721065405.GA9793@coredump.intra.peff.net>
In-Reply-To: <alpine.LFD.0.999.0707202335570.27249@woody.linux-foundation.org>

On Fri, Jul 20, 2007 at 11:47:24PM -0700, Linus Torvalds wrote:

> So the difference between your version and mine is that the
> 
> 	while ((p = *pp) != NULL)

I actually like your version better (I like saving for loops for
honest-to-god, for-each-element-in-this-list iteration; munging the list
in the middle is something that you _should_ call attention to). I just
found your patch much harder to verify, because I had to make sure the
for/while change was equivalent. So you can blame Junio for writing it
wrong in the first place. :)

Junio, whatever you apply, please credit Linus; he beat me to the fix
and so my patch is completely cribbed from his. :)

-Peff