git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gitk problems: can't unset "idinlist(...)"

From
Jeff King <peff@peff.net>
Date
Jul 21, 2007, 06:18 UTC
Message-ID
<20070721061857.GB29820@coredump.intra.peff.net>
In-Reply-To
<alpine.LFD.0.999.0707202304350.27249@woody.linux-foundation.org>
On Fri, Jul 20, 2007 at 11:11:19PM -0700, Linus Torvalds wrote:
> Here's a patch. Not very well tested, but it makes gitk happy and passes 
> all the tests. And I really think Junio's code was very dubious (it did 
> that "p = p->next" *every* time, and then did "pp = &p->next", so "pp" 
> would end up jumping by multiple entries.

I just independently came to the same conclusion. Your patch looks correct to me (though there are some unrelated formatting changes which made it a little harder to read).

Acked-by: Jeff King <peff@peff.net>
-Peff
Previous: Linus TorvaldsNext: Jeff King
Message 8 of 15 in “gitk problems: can't unset "idinlist(...)"”
  1. Linus TorvaldsJul 20, 2007
  2. Jeff KingJul 21, 2007
  3. Linus TorvaldsJul 21, 2007
  4. Junio C HamanoJul 21, 2007
  5. Jeff KingJul 21, 2007
  6. Jeff KingJul 21, 2007
  7. Linus TorvaldsJul 21, 2007
  8. Jeff KingJul 21, 2007
  9. Jeff KingJul 21, 2007
  10. Linus TorvaldsJul 21, 2007
  11. Jeff KingJul 21, 2007
  12. pointer to pointer (was: gitk problems: can't unset "idinlist(...)")David Kastrup, Jul 21, 2007
  13. David KastrupJul 21, 2007
  14. Linus TorvaldsJul 21, 2007
  15. Paul MackerrasJul 21, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.