Re: gitk problems: can't unset "idinlist(...)"

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Jul 21, 2007, 06:34 UTC
Message-ID: <alpine.LFD.0.999.0707202329220.27249@woody.linux-foundation.org>
In-Reply-To: <20070721061857.GB29820@coredump.intra.peff.net>

On Sat, 21 Jul 2007, Jeff King wrote:

> 
> I just independently came to the same conclusion. Your patch looks
> correct to me (though there are some unrelated formatting changes which
> made it a little harder to read).

Yeah, I shouldn't have done that - I just ended up changing the "for()" to a "while()" (because we should *not* do the same thing at the end of the loop each time). And as a part of that I changed the initialization to be at the head of the while-loop rather than in the variable declaration, because that's how I tend to mostly write while-loops.

But I probably should have tried to keep the patch minimal instead, so that it would show the changes better. Probably not a big deal.

		Linus