From: Jeff King <peff@peff.net>
Date: Sat, 21 Jul 2007 06:18:57 GMT
Subject: Re: gitk problems: can't unset "idinlist(...)"
Message-ID: <20070721061857.GB29820@coredump.intra.peff.net>
In-Reply-To: <alpine.LFD.0.999.0707202304350.27249@woody.linux-foundation.org>

On Fri, Jul 20, 2007 at 11:11:19PM -0700, Linus Torvalds wrote:

> Here's a patch. Not very well tested, but it makes gitk happy and passes 
> all the tests. And I really think Junio's code was very dubious (it did 
> that "p = p->next" *every* time, and then did "pp = &p->next", so "pp" 
> would end up jumping by multiple entries.

I just independently came to the same conclusion. Your patch looks
correct to me (though there are some unrelated formatting changes which
made it a little harder to read).

Acked-by: Jeff King <peff@peff.net>

-Peff