Re: [RFC/PATCH] Optimized PowerPC SHA1 generation for Darwin (OS X)
- From
Arjen Laarhoven <arjen@yaph.org>
- Date
- Apr 10, 2007, 11:45 UTC
- Message-ID
- <20070410114507.GA28728@regex.yaph.org>
- In-Reply-To
- <20070410094801.GA6148@diana.vm.bytemark.co.uk>
Hi,
On Tue, Apr 10, 2007 at 11:48:01AM +0200, Karl Hasselstr?m wrote:
Show 7 quoted lines
> On 2007-04-08 22:09:39 +0200, Arjen Laarhoven wrote:
>
> > ppc/{sha1ppc.S => sha1ppc.in.S} | 110 +++++++++++++++++++-------------------
>
> Wouldn't it be prettier if this filename was .S.in instead of .in.S?
> Additional file suffixes are usually added at the end (e.g. .tar.gz),
> and it makes more sense too.Using the .S suffix makes gcc automatically do the right thing. .S.in requires an extra '-x assembler-with-cpp' option to gcc. Of course, it's trivial fix.
Arjen