Re: [RFC/PATCH] Optimized PowerPC SHA1 generation for Darwin (OS X)

From: Karl Hasselström <kha@treskal.com>
Date: Apr 10, 2007, 13:00 UTC
Message-ID: <20070410130050.GA10104@diana.vm.bytemark.co.uk>
In-Reply-To: <20070410114507.GA28728@regex.yaph.org>

On 2007-04-10 13:45:07 +0200, Arjen Laarhoven wrote:

Show 13 quoted lines

> On Tue, Apr 10, 2007 at 11:48:01AM +0200, Karl Hasselström wrote:
>
> > On 2007-04-08 22:09:39 +0200, Arjen Laarhoven wrote:
> >
> > >  ppc/{sha1ppc.S => sha1ppc.in.S} |  110 +++++++++++++++++++-------------------
> >
> > Wouldn't it be prettier if this filename was .S.in instead of
> > .in.S? Additional file suffixes are usually added at the end (e.g.
> > .tar.gz), and it makes more sense too.
>
> Using the .S suffix makes gcc automatically do the right thing.
> .S.in requires an extra '-x assembler-with-cpp' option to gcc. Of
> course, it's trivial fix.

I just read the Makefile changes again, a bit slower this time, and noticed that you _first_ feed the .in.S file to gcc, and _then_ to the perl script, instead of the other way around like I was expecting. With that arrangement, your naming makes sense, since it reflects which file format is contained in which. Sorry for the noise.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle