Re: [RFC/PATCH] Optimized PowerPC SHA1 generation for Darwin (OS X)
- From
Junio C Hamano <junkio@cox.net>
- Date
- Apr 7, 2007, 00:47 UTC
- Message-ID
- <7vodm1ggdm.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20070406234826.GG3854@regex.yaph.org>
arjen@yaph.org (Arjen Laarhoven) writes:
Show 6 quoted lines
> The compiler toolchain supplied by Apple's Xcode environment has an old > version (1.38) of the GNU assembler. It cannot assemble the optimized > ppc/sha1ppc.S file. ppc/sha1ppc.S was rewritten into a Perl script > which outputs the same code, but valid for the Xcode assembler. > > Signed-off-by: Arjen Laarhoven <arjen@yaph.org>
Gaah.
When there are improvements/fixes to the sha1ppc.S side, how are you going to keep that in sync with darwin_ppc_gen.pl? If that script *_gen.pl were a postprocessor that munges CPP output from sha1ppc.S to make it assemblable with an old assembler, it would be one thing. But this looks horrible.