git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] Rename remote_only to display_mode

From
APAndy Parkins <andyparkins@gmail.com>
Date
Nov 3, 2006, 08:40 UTC
Message-ID
<200611030841.05888.andyparkins@gmail.com>
In-Reply-To
<7v64dxl0bf.fsf@assigned-by-dhcp.cox.net>
On Friday 2006 November 03 02:40, Junio C Hamano wrote:
> If you make this a "mode", it probably is better to make 1 and 0
> into symbolic constants.  This patch taken alone is regression
> in readability.

In my own code I would have done exactly that; however I've been trying to keep my patches as minimal as possible.

Digressing a little: what is the polite form of patches for git? My strategy with this set was to make each patch as small as possible to reach my end point. If those patches were okayed on the list, I could then do a "make more beautiful" patch, which is really nothing to do with the original changes to functionality but would make the code prettier. Really I'm asking what level of intrusiveness of patch is not considered rude? In making my patches, should I ride rough-shod over current implementation and just do it how I'd do it or should I try to fit in (as I did in this case)?

> Something like this untested patch, that is...
I'm very much in favour; I shall make changes of this form soon.
Andy
-- 
Dr Andy Parkins, M Eng (hons), MIEE
Previous: Junio C HamanoNext: Andreas Ericsson
Message 3 of 23 in “Rename remote_only to display_mode”
  1. 2/4 Rename remote_only to display_modeAndy Parkins, Nov 2, 2006
  2. Junio C HamanoNov 3, 2006
  3. Andy ParkinsNov 3, 2006
  4. Andreas EricssonNov 3, 2006
  5. Junio C HamanoNov 3, 2006
  6. Andy ParkinsNov 3, 2006
  7. Andy ParkinsNov 3, 2006
  8. Andreas EricssonNov 3, 2006
  9. Add support to git-branch to show local and remote branchesAndy Parkins, Nov 3, 2006
  10. Colourise git-branch outputAndy Parkins, Nov 3, 2006
  11. Junio C HamanoNov 3, 2006
  12. Alex RiesenNov 3, 2006
  13. Junio C HamanoNov 3, 2006
  14. Andy ParkinsNov 3, 2006
  15. Junio C HamanoNov 3, 2006
  16. 3/4 Default to displaying /all/ non-tag refs, not just localsAndy Parkins, Nov 2, 2006
  17. Junio C HamanoNov 3, 2006
  18. Andy ParkinsNov 3, 2006
  19. Andreas EricssonNov 3, 2006
  20. 4/4 Show the branch type after the branch name for remotesAndy Parkins, Nov 2, 2006
  21. Junio C HamanoNov 3, 2006
  22. Andy ParkinsNov 3, 2006
  23. Junio C HamanoNov 3, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.