git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] Rename remote_only to display_mode

From
APAndy Parkins <andyparkins@gmail.com>
Date
Nov 3, 2006, 12:00 UTC
Message-ID
<200611031200.27275.andyparkins@gmail.com>
In-Reply-To
<454B1F3B.1020603@op5.se>
On Friday 2006 November 03 10:51, Andreas Ericsson wrote:
Show 6 quoted lines
> If you *need* to change something, change it. If you *want* to change
> something just because it's not written the way you would write it, back
> away. If you think some interface you're using needs clearing up
> (codewise or with extra comments), send a separate patch for that so the
> actual feature/bugfix you're sending in doesn't drown in cosmetic
> changes to the interfaces the patch uses/touches.

Thank you for the excellent advice. What then would you suggest in the case in point? I made as minimal a change as I could make; but that left the code a little bit bitty - I had press-ganged a variable into taking on another function and was using numeric literals that should really have been given meaning with #define?

My question is perhaps different from simply git-etiquette; it's should I prefer my patches to be minimal or neat? If there is a more appropriate way of doing something should I do it or should I favour minimalism?

I've actually rewritten it now as per Junio's request, and while I'm happier with the code, it was much bigger change, that didn't really lend itself to being broken into smaller patches as did my first attempt.

I guess in the end it's a judgement call and the best thing to do is post it and see who shoots it down :-)

Andy
-- 
Dr Andy Parkins, M Eng (hons), MIEE
Previous: Andy ParkinsNext: Andreas Ericsson
Message 7 of 23 in “Rename remote_only to display_mode”
  1. 2/4 Rename remote_only to display_modeAndy Parkins, Nov 2, 2006
  2. Junio C HamanoNov 3, 2006
  3. Andy ParkinsNov 3, 2006
  4. Andreas EricssonNov 3, 2006
  5. Junio C HamanoNov 3, 2006
  6. Andy ParkinsNov 3, 2006
  7. Andy ParkinsNov 3, 2006
  8. Andreas EricssonNov 3, 2006
  9. Add support to git-branch to show local and remote branchesAndy Parkins, Nov 3, 2006
  10. Colourise git-branch outputAndy Parkins, Nov 3, 2006
  11. Junio C HamanoNov 3, 2006
  12. Alex RiesenNov 3, 2006
  13. Junio C HamanoNov 3, 2006
  14. Andy ParkinsNov 3, 2006
  15. Junio C HamanoNov 3, 2006
  16. 3/4 Default to displaying /all/ non-tag refs, not just localsAndy Parkins, Nov 2, 2006
  17. Junio C HamanoNov 3, 2006
  18. Andy ParkinsNov 3, 2006
  19. Andreas EricssonNov 3, 2006
  20. 4/4 Show the branch type after the branch name for remotesAndy Parkins, Nov 2, 2006
  21. Junio C HamanoNov 3, 2006
  22. Andy ParkinsNov 3, 2006
  23. Junio C HamanoNov 3, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.