Re: [PATCH] Add support to git-branch to show local and remote branches

From: Junio C Hamano <junkio@cox.net>
Date: Nov 3, 2006, 19:19 UTC
Message-ID: <7vac388hig.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200611031240.34177.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

Show 14 quoted lines

> On Friday 2006 November 03 12:08, Junio C Hamano wrote:
>
>> > +static int tidy_ref_list( struct ref_list *ref_list )
>>
>> Style.  No spaces before or after parameter list.
>
> Bah!  It's so hard getting my fingers to remember what style goes in which 
> project :-)
>
>> I see you already parse "refs/tags" prefix. "git branch" would
>> not print tags, but that part might be useful when we want to
>> redo git-tag in C.
>
> I'm going to have a look at that soon;...

Just to make sure you do not misunderstand. I do not see much need for rewriting git-tag in C right now, and often it is more convenient to leave higher layer commands in shell scripts to allow people to try out new things and flush out UI issues. I was merely pointing out that part of the code would be usable if we were to do it.