From: Andy Parkins Date: Fri, 03 Nov 2006 08:40:55 GMT Subject: Re: [PATCH 2/4] Rename remote_only to display_mode Message-ID: <200611030841.05888.andyparkins@gmail.com> In-Reply-To: <7v64dxl0bf.fsf@assigned-by-dhcp.cox.net> On Friday 2006 November 03 02:40, Junio C Hamano wrote: > If you make this a "mode", it probably is better to make 1 and 0 > into symbolic constants. This patch taken alone is regression > in readability. In my own code I would have done exactly that; however I've been trying to keep my patches as minimal as possible. Digressing a little: what is the polite form of patches for git? My strategy with this set was to make each patch as small as possible to reach my end point. If those patches were okayed on the list, I could then do a "make more beautiful" patch, which is really nothing to do with the original changes to functionality but would make the code prettier. Really I'm asking what level of intrusiveness of patch is not considered rude? In making my patches, should I ride rough-shod over current implementation and just do it how I'd do it or should I try to fit in (as I did in this case)? > Something like this untested patch, that is... I'm very much in favour; I shall make changes of this form soon. Andy -- Dr Andy Parkins, M Eng (hons), MIEE