git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: tree view: hash_base and hash are now context sensitive

From
LTLuben Tuikov <ltuikov@yahoo.com>
Date
Sep 29, 2006, 23:30 UTC
Message-ID
<20060929233037.42926.qmail@web31808.mail.mud.yahoo.com>
In-Reply-To
<200609292235.27478.jnareb@gmail.com>
--- Jakub Narebski <jnareb@gmail.com> wrote:
Show 7 quoted lines
> As a interim solution it is a good idea, moreover with using $hash_base
> defaulting to HEAD instead of using HEAD literaly.
> 
> The correct solution would be to make "html" page (i.e. "blob" not 
> "blob_plain" view) also for binary files. <img> element for image/*
> mimetype, perhaps <embed> or <object>, or just plain link for other
> binary (not text/* or some application/*) types

We already do have a hash_base context. It is what allows us to "select" a revision from shortlog and ask "tree", "history", etc from there on, having set "h" and/or "hb".

What this patch does is simply set "h" and/or "hb" to the string "HEAD" instead of the string "<SHA1 of HEAD>" when h/hb is not defined.

    Luben
Show 6 quoted lines
> 
> I was AFK for few days.
> -- 
> Jakub Narebski
> Poland
>
Previous: Jakub NarebskiNext: Jakub Narebski
Message 10 of 12 in “gitweb: tree view: hash_base and hash are now context sensitive”
  1. gitweb: tree view: hash_base and hash are now context sensitiveLuben Tuikov, Sep 26, 2006
  2. Jakub NarebskiSep 26, 2006
  3. Luben TuikovSep 26, 2006
  4. Junio C HamanoSep 27, 2006
  5. Luben TuikovSep 27, 2006
  6. Luben TuikovSep 28, 2006
  7. Junio C HamanoSep 29, 2006
  8. Luben TuikovSep 29, 2006
  9. Jakub NarebskiSep 29, 2006
  10. Luben TuikovSep 29, 2006
  11. Jakub NarebskiOct 1, 2006
  12. Luben TuikovOct 2, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.