Re: [PATCH] gitweb: tree view: hash_base and hash are now context sensitive
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Sep 29, 2006, 20:35 UTC
- Message-ID
- <200609292235.27478.jnareb@gmail.com>
- In-Reply-To
- <20060929161619.24848.qmail@web31806.mail.mud.yahoo.com>
Luben Tuikov wrote:
Show 7 quoted lines
> --- Junio C Hamano <junkio@cox.net> wrote: > > > What are the objections to this patch? > > > > No objections from me --- rather lack of objections from Jakub ;-) > > We haven't heard anything from him, and on our last correspondence > in this thread it seemed we're in agreement.
As a interim solution it is a good idea, moreover with using $hash_base defaulting to HEAD instead of using HEAD literaly.
The correct solution would be to make "html" page (i.e. "blob" not "blob_plain" view) also for binary files. <img> element for image/* mimetype, perhaps <embed> or <object>, or just plain link for other binary (not text/* or some application/*) types
I was AFK for few days.
-- Jakub Narebski Poland