Re: [PATCH] gitweb: tree view: hash_base and hash are now context sensitive
Luben Tuikov <ltuikov@yahoo.com> writes:
Show 18 quoted lines
>> > > Agreed, we should always refer to the commit-ish, for obvious
>> > > reasons.
>> > >
>> > > This patch doesn't make this decision though. It simply
>> > > sets hash_base to HEAD if not defined.
>> > >
>> > > Now, since "git-ls-tree" works on both commit-ish and
>> > > tree-ish, we are ok.
>> >
>> > I think so, too. Jakub?
>>
>> Status? I see Jakub hasn't objected, and it is really important
>> for us to be able to link to "latest" binary blob -- for example
>> a PDF spec file.
>
> Junio,
>
> What are the objections to this patch?
No objections from me --- rather lack of objections from Jakub ;-)
But the fragments do not appear to apply anymore.
@@ -1625,7 +1625,7 @@ sub git_print_tree_entry {
"history");
}
print " | " .
- $cgi->a({-href => href(action=>"blob_plain", hash_base=>"HEAD",
+ $cgi->a({-href => href(action=>"blob_plain", hash_base=>$hash_base,
file_name=>"$basedir$t->{'name'}")},
"raw");
print "</td>\n";
There is no call to create blob_plain link with hash_base
hardcoded to "HEAD" in git-print-tree-entry.
Care to re-spin?
Junio C Hamano <junkio@cox.net>