From: Luben Tuikov <ltuikov@yahoo.com>
Date: Fri, 29 Sep 2006 23:30:36 GMT
Subject: Re: [PATCH] gitweb: tree view: hash_base and hash are now context sensitive
Message-ID: <20060929233037.42926.qmail@web31808.mail.mud.yahoo.com>
In-Reply-To: <200609292235.27478.jnareb@gmail.com>

--- Jakub Narebski <jnareb@gmail.com> wrote:
> As a interim solution it is a good idea, moreover with using $hash_base
> defaulting to HEAD instead of using HEAD literaly.
> 
> The correct solution would be to make "html" page (i.e. "blob" not 
> "blob_plain" view) also for binary files. <img> element for image/*
> mimetype, perhaps <embed> or <object>, or just plain link for other
> binary (not text/* or some application/*) types

We already do have a hash_base context. It is what allows us to
"select" a revision from shortlog and ask "tree", "history", etc
from there on, having set "h" and/or "hb".

What this patch does is simply set "h" and/or "hb" to
the string "HEAD" instead of the string "<SHA1 of HEAD>" when
h/hb is not defined.

    Luben


> 
> I was AFK for few days.
> -- 
> Jakub Narebski
> Poland
>