Re: [PATCH v2 06/20] t1092: compare sparse-checkout to sparse-index

From: Derrick Stolee <stolee@gmail.com>
Date: Mar 11, 2021, 14:17 UTC
Message-ID: <1efcb012-53d7-9939-7fa3-ab45cdc1a6fa@gmail.com>
In-Reply-To: <CABPp-BG6eSpjHVU5XShi17MOuPku=U388rL1=JXXF88M4ymFHA@mail.gmail.com>

On 3/10/2021 6:04 PM, Elijah Newren wrote:

Show 9 quoted lines

> On Wed, Mar 10, 2021 at 11:31 AM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> Add GIT_TEST_SPARSE_INDEX environment variable to enable the
>> sparse-index by default. This will be intended to use across the entire
>> test suite, except that it will only affect cases where the
>> sparse-checkout feature is enabled.
> 
> This last sentence was a bit awkward to read.  "will be intended to
> use" -> "is intended to be used"?

Fixed locally to:

    Add the GIT_TEST_SPARSE_INDEX environment variable to enable the
    sparse-index by default. This can be enabled across all tests, but that
    will only affect cases where the sparse-checkout feature is enabled.

Show 6 quoted lines

>> +test_sparse_match () {
>> +       run_on_sparse $* &&
> 
> Should this be
>    run_on_sparse "$@"
> in order to allow arguments with spaces?

Sorry I missed this one. It was fixed to the right use in
"sparse-index: convert from full to sparse" so I thought I
had already covered this one when looking at the tip of my
branch.
 
Thanks,
-Stolee