Re: [PATCH v2 11/20] sparse-index: convert from full to sparse

From: Derrick Stolee <stolee@gmail.com>
Date: Mar 11, 2021, 14:13 UTC
Message-ID: <1241c484-62ce-5acb-794e-444ba2cdc4c2@gmail.com>
In-Reply-To: <CABPp-BGUqVC7JV7nnNDTt++rHCxUF+98T0OLq5dFf0mOKkp8fw@mail.gmail.com>

On 3/10/2021 6:44 PM, Elijah Newren wrote:

Show 10 quoted lines

> On Wed, Mar 10, 2021 at 11:31 AM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> +GIT_TEST_CHECK_CACHE_TREE=0
> 
> I still think it'd be nice to get a comment, either in the code or the
> commit message, explaining why your series needs to set
> GIT_TEST_CHECK_CACHE_TREE to 0.  I feel like I should almost know the
> answer (was this just a preliminary step and it'll later be turned on?
> did the cache-tree checking do stuff that assumes no sparse directory
> entries? is it really slow?), but I don't.

Sorry I missed commenting on this earlier.

The GIT_TEST_CHECK_CACHE_TREE environment is enabled by the test suite by default and it does extra validation to see that the cache-tree extension exists and matches the index contents. Since at this point we don't have the cache-tree extension enabled with sparse-index, we would start getting failures by those tests.

This is re-enabled in "sparse-index: loose integration with cache_tree_verify()" so everything is being verified at the end of the series.

Thanks, -Stolee