From: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Date: Tue, 21 Aug 2012 09:47:25 GMT
Subject: Re: [PATCH v5 15/16] remote-svn: add marks-file regeneration
Message-ID: <1894713.otuKr9xS8H@flomedio>
In-Reply-To: <7va9xpgngk.fsf@alter.siamese.dyndns.org>

On Monday 20 August 2012 16:20:27 Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> > I think you meant something like:
> > 
> >       init_notes(NULL, notes_ref, NULL, 0);
> >
> >         marksfile = fopen(marksfilename, "r");
> >         if (!marksfile) {
> >               regenerate_marks(marksfilename);
> >                 marksfile = fopen(marksfilename, "r");

Btw, this is FILE* is nowhere closed in your fixuped version in fa/remote-svn.

> >                 if (!marksfile)
> >
> >                       die("cannot read marks file!");
> >       } else {
> >
> >               ...