[PATCH v2 06/22] git-remote-mediawiki: Rewrite unclear line of instructions
- From
Célestin Matte <celestin.matte@ensimag.fr>
- Date
- Jun 7, 2013, 21:42 UTC
- Message-ID
- <1370641344-4253-7-git-send-email-celestin.matte@ensimag.fr>
- In-Reply-To
- <1370641344-4253-1-git-send-email-celestin.matte@ensimag.fr>
Subroutines' parameters should be affected to variable before doing anything else Besides, existing instruction affected a variable inside a "if", which break Git's coding style
Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr> Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr> --- contrib/mw-to-git/git-remote-mediawiki.perl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl index 5e348cb..a5c963b 100755 --- a/contrib/mw-to-git/git-remote-mediawiki.perl +++ b/contrib/mw-to-git/git-remote-mediawiki.perl @@ -1334,7 +1334,8 @@ sub get_mw_namespace_id { } sub get_mw_namespace_id_for_page { - if (my ($namespace) = $_[0] =~ /^([^:]*):/) { + my $namespace = shift; + if ($namespace =~ /^([^:]*):/) { return get_mw_namespace_id($namespace); } else { return;
-- 1.7.9.5