git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/7] unpack-trees: factor out dup_entry

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
May 30, 2013, 11:34 UTC
Message-ID
<1369913664-49734-4-git-send-email-rene.scharfe@lsrfire.ath.cx>
In-Reply-To
<1369913664-49734-1-git-send-email-rene.scharfe@lsrfire.ath.cx>

While we're add it, mark the struct cache_entry pointer of add_entry const because we only read from it and this allows callers to pass in const pointers.

Signed-off-by: René Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 unpack-trees.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/unpack-trees.c b/unpack-trees.c
index ede4299..e8b4cc1 100644
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -116,14 +116,20 @@ static void do_add_entry(struct unpack_trees_options *o, struct cache_entry *ce,
 			ADD_CACHE_OK_TO_ADD | ADD_CACHE_OK_TO_REPLACE);
 }
 
-static void add_entry(struct unpack_trees_options *o, struct cache_entry *ce,
-	unsigned int set, unsigned int clear)
+static struct cache_entry *dup_entry(const struct cache_entry *ce)
 {
 	unsigned int size = ce_size(ce);
 	struct cache_entry *new = xmalloc(size);
 
 	memcpy(new, ce, size);
-	do_add_entry(o, new, set, clear);
+	return new;
+}
+
+static void add_entry(struct unpack_trees_options *o,
+		      const struct cache_entry *ce,
+		      unsigned int set, unsigned int clear)
+{
+	do_add_entry(o, dup_entry(ce), set, clear);
 }
 
 /*
-- 
1.8.3
Previous: René ScharfeNext: Peter Krefting
Message 4 of 12 in “unpack-trees: plug memory leak for merges”
  1. 0/7 unpack-trees: plug memory leak for mergesRené Scharfe, May 30, 2013
  2. 1/7 cache: mark cache_entry pointers constRené Scharfe, May 30, 2013
  3. 2/7 read-cache: mark cache_entry pointers constRené Scharfe, May 30, 2013
  4. 3/7 unpack-trees: factor out dup_entryRené Scharfe, May 30, 2013
  5. Peter KreftingJun 4, 2013
  6. 4/7 unpack-trees: create working copy of merge entry in merged_entryRené Scharfe, May 30, 2013
  7. 5/7 diff-lib, read-tree, unpack-trees: mark cache_entry pointers constRené Scharfe, May 30, 2013
  8. 6/7 diff-lib, read-tree, unpack-trees: mark cache_entry array paramters constRené Scharfe, May 30, 2013
  9. 7/7 unpack-trees: free cache_entry array members for mergesRené Scharfe, May 30, 2013
  10. Felipe ContrerasMay 30, 2013
  11. René ScharfeMay 30, 2013
  12. Felipe ContrerasMay 30, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.